test+docs: drift guards batch — grammar completeness, docs sync, surface-authority honesty (architecture review F1/F6/F9) - #57
Merged
Conversation
…ace-authority honesty (architecture review F1/F6/F9) The F1 accept-and-pin ruling made executable: a grammar-wide completeness test (every QuestionType must have table rows and construct-specific output on all four surfaces), docs drift tests for the hand-maintained README/SKILL grammar docs, the adding-a-construct touchpoint checklist, and advisory-status honesty on select_form_surface. Mutation-checked: changing README's construct count fails red. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #53 (auto-closed when its stacked base branch
claude/forms-cleanup-batchwas deleted on #52's merge). Rebased ontomain— #52's commits dropped since they're now in main via squashfc7c653; only this batch's single commit replays. 723 tests green, ruff clean.Batch C of the 2026-08-20 dynamic-forms architecture review — the drift-catcher pins for the accepted per-construct cost (F1/F6/F9):
tests/test_grammar_completeness.py(F1): everyQuestionTypemust carry a row in the completeness tables and emit construct-specific output on all four surfaces — a construct wired into only three, or a 16th type added without updating the tables, fails red.tests/test_docs_drift.py(F6): README's spelled-out construct count tracks the enum; README/SKILL.md must describe every construct; every MCP tool /x_to_yfunction the skill names must exist.docs/adding-a-construct.md: the 19-touchpoint checklist with anchors and the rejected alternatives recorded.select_form_surfacedocstring + README state the router is advisory in the shipped plugin (agent MCP tool choice is the effective decision).Not in this batch (release-gated → 0.7.0, Batch D): SKILL.md step 4's library-only markdown-call instruction (F3).
🤖 Generated with Claude Code