test(golden): graduate hard-query xfails to hard assertions - #218
Merged
Conversation
The hard-difficulty golden queries carried xfail(strict=False) pending an embeddings retriever (task 2.5 gate). All three now pass via alias expansion + path-keyed summaries, and the embeddings retriever is permanently deferred (docs/specs/archive/alias-expansion-sweep/) — the marks only masked regressions. Paraphrased info-only xfails and the aggregate watermark are untouched; their gating decision remains deferred per M13.3. Golden suite: 41 passed, 2 xfailed (paraphrased), 78 xpassed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Perf delta — within baselineBlocking on regression in:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hard-difficulty golden queries have carried
xfail(strict=False)since the marks were added to document the keyword-retriever gap, gated on an embeddings retriever (task 2.5). Two facts make the marks obsolete:Scope: removes
_entry_marksso all difficulties assert hard, and records the graduation in the module docstring. The paraphrased info-only xfail set and the aggregate R@3 watermark are deliberately untouched — their threshold-gating decision remains deferred per M13.3.Verification: golden suite 41 passed / 2 xfailed (known paraphrased misses gqp-015b, gqp-031a) / 78 xpassed; full suite green locally on top of #217.
Supersedes the stale May branch
fix/golden-drop-stale-xfail(deleted in today's housekeeping sweep).🤖 Generated with Claude Code