Per-webhook timeout, watched-asset validation, structured error codes, ESLint CI step - #259
Merged
ritaifeoluwa merged 1 commit intoAug 26, 2026
Conversation
- webhookDispatcher.js: postOnce accepts a per-webhook timeoutMs override, falling back to the global config default, instead of a single global timeout for every subscriber - schemas.js: alert creation now rejects asset codes not present in config.watchedAssets (when that list is configured), instead of accepting any string silently - errorHandler.js: the generic status-based fallback branch now maps common HTTP statuses (400/401/403/404/429) to their matching structured error code instead of hardcoding every one as FORBIDDEN - eslint.config.js + ci.yml: adds a minimal ESLint flat config and a non-blocking lint step in CI as a starting point Closes SmartDropLabs#228 Closes SmartDropLabs#229 Closes SmartDropLabs#230 Closes SmartDropLabs#231
|
@adenikeakan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webhookDispatcher.js: delivery timeout can now be overridden per-webhook viawebhook.timeoutMs, falling back to the existing global default (No webhook delivery timeout per subscriber #228)schemas.js: alert creation rejects asset codes outsideconfig.watchedAssetswhen that list is configured (No alert asset validation against Stellar asset registry #229)errorHandler.js: the generic status-based error branch now maps common HTTP statuses to their matching structured code instead of always returningFORBIDDEN(No structured error codes for all API responses #230)Issues
Closes #228
Closes #229
Closes #230
Closes #231
Test plan
node -con all touched JS files