RPS-10045 Bulk downloading job files#101
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces job-based pull functionality to the Smartling CLI, allowing users to download files associated with a specific translation job via the --job-uid flag. It also adds a --resume flag to skip existing files and a --dry-run flag to preview the download matrix. Supporting changes include dependency updates, new path formatting defaults, and comprehensive unit tests. Review feedback identifies an issue where errors in parallel download workers are swallowed, preventing the CLI from reporting failures correctly. There is also a recommendation to unify error handling when a job contains no target locales to ensure consistent CLI exit codes.
|
|
Added
--job-uidtofiles pullso customers can download every file × target-locale pair from a Smartling translation job in one command.New flags on
files pull:--job-uid <uid>— pull all files × target locales from the job (composes with<uri>glob,--locale,--directory, etc.)--dry-run— preview the file × locale matrix without downloading--resume— skip files already on disk--threads N— moved from global root flag to local; reads fromsmartling.ymlas fallback (default 20)Depends on Smartling/api-sdk-go#31 for the new
JobApi.ListFilespaginated method andGetJob.TargetLocaleIDsfield.Per-file download failures are now tallied and surfaced as a non-zero error instead of being silently swallowed.