π¦ New version release - #546
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@smooai/smooth-operator@1.58.3
Patch Changes
330680e: fix(server): a storage blip is no longer reported as
session '<id>' not foundAppState::load_sessionhydrates a session from storage when the localper-pod registry misses (th-ca579c) β the normal path for a returning visitor
whose WebSocket lands on a pod that has never seen their session. That read
collapsed
ErrintoNone, so a transient Postgres failure wasindistinguishable from a session that genuinely does not exist. Every caller
renders
Noneassession '<id>' not found, so a backend hiccup told a livevisitor on smoo.ai, in the chat bubble, that their conversation was gone. Seen
in production.
load_sessionnow returnsanyhow::Result<Option<Session>>andhandler::scoped_sessionpropagates it. The three outcomes are distinct at theuser-visible boundary:
Ok(Some(session))β unchanged.Ok(None)β not found, or not yours: still the identicalSESSION_NOT_FOUND/NO_PENDING_*event, byte for byte, so there is noexistence oracle to enumerate other users' session ids with.
Err(_)β storage could not answer: a retryableSTORAGE_ERROR("sessionlookup is temporarily unavailable, please try again"), which is not an
existence claim and leaks nothing (a storage failure is independent of
whether the id is real or ours). The underlying error is logged server-side,
not sent to the client.
All six session-id-taking actions route through the one chokepoint and switch
together:
get_session,get_conversation_messages,send_messageandverify_otp(previouslySESSION_NOT_FOUND), plusconfirm_tool_actionandsubmit_interaction(previouslyNO_PENDING_CONFIRMATION/NO_PENDING_INTERACTION, which for a parked turn was equally wrong β the parkis still there, and a retry still resolves it).
rust/smooth-operator-server/tests/session_storage_blip.rsdrives the realdispatcher against a storage adapter whose
get_sessionfails on demand andpins both halves: a blip is never rendered as not-found on any of the six
actions, and a genuinely unknown id still is (a fix that made everything
retryable would leave clients retrying an id that will never resolve).
Host-facing API change:
AppState::load_sessionreturnsanyhow::Result<Option<Session>>instead ofOption<Session>β hosts callingit directly add a
?or amatch.@smooai/smooth-operator-web-chat-example@0.0.116
Patch Changes