Add GitHub Actions CI: install, lint, build - #7
Merged
Conversation
There was no CI pipeline on this repo at all, every PR so far has been merged on trust with checks run locally by whoever reviewed it. Add a workflow that runs on push to main and on pull requests: npm install, npm run lint, npm run build. Lint had no eslintrc anywhere in the repo (called out in PR #6), so next lint couldn't run as-is. Added a minimal one extending next/core-web-vitals, confirmed it runs clean. Also committing package-lock.json since it didn't exist before and actions/setup-node's npm cache needs a lockfile to key off of. Build will show red on main until the pre-existing BigInt-literal vs tsconfig target mismatch in streams/[id]/page.tsx is fixed, that's not part of this change, just making the existing gap visible in CI instead of only surfacing when someone happens to run a local build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's been no CI on this repo, every PR so far has gone in on trust with whoever's reviewing running checks locally themselves. Adding a workflow that runs on push to main and on every PR: install, lint, build.
Lint had no eslintrc committed anywhere (this was actually called out in #6), so
next lintcouldn't run as-is. Added a minimal one extendingnext/core-web-vitals, ran it locally, comes back clean.Also committing package-lock.json since one didn't exist in the repo before, needed it for the npm cache step in the workflow to have something to key off of.
Heads up: build will come back red on main right now, there's a pre-existing BigInt-literal vs tsconfig target mismatch in streams/[id]/page.tsx (also flagged in #6). Not fixing that here, this PR is just about getting CI in place so that kind of thing shows up automatically instead of only when someone happens to build locally.