feat: add trustline policies, cost forecasts, and refund workflows - #494
Merged
Conversation
feat: add trustline policies, cost forecasts, and refund workflows
|
@El-Chapo-Npm Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the four requested Sorokit improvements:
Adds explicit issuer and asset trustline approval policies, existing-trustline detection, duplicate suppression, and safe delegation to the current bulk trustline builder.
Adds deterministic transaction cost analysis, configurable historical summaries, planned-operation forecasting, and budget warnings with graceful missing-fee handling.
Adds reverseTransaction() and issueRefund() workflows for supported payments, including full and partial refunds, amount validation, ambiguity checks, and structured errors.
Expands documentation with executable lifecycle, wallet, multisignature, Soroban, trustline, refund, recovery, architecture, and migration guides.
Issues closed
Closes #472
Closes #471
Closes #468
Closes #479
Verification
Focused feature tests: 7 passed.
Existing trustline and fee regression tests: 41 passed.
ESLint on changed TypeScript files: passed.
git diff --check: passed.
Example typecheck: passed.
Repository build emits JS successfully, but declaration generation remains blocked by pre-existing strict optional-property errors in src/soroban/nftMetadata.ts and src/transaction/bundles.ts.