Rust 2024 apparently?#461
Open
Metekillot wants to merge 3 commits into
Open
Conversation
Owner
|
Directionally correct, but:
|
Contributor
Author
I'm making a heavily modified fork as a submodule for interoperability with an LSP CLI tool I'm making, and I'm using Rust 2024 on it; I wanted to minimize friction for anything I'd PR upstream or pull from it when it's aligned with base SDMM functionality. Rust 2024 seems like it does some things differently with syntax and unsafe blocks and, I think other things too for some standard library stuff; I don't know enough about Rust to speak authoritatively.
I can fix that.
I will look into this; I'm compiling on Linux but I believe I was running into some issues with MSVC over the gnu compiler for windows cross compiling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this time I'm honestly kind of in an uneasy daze because this was much more straightforward than I anticipated. I assume I'm missing some important build step and I'm actually building in 2021 still.
In any case, I just changed all the Cargo.toml files to use the 2024 edition then made the changes the compiler told me to until it compiled. All the tests are passing as well.