Reuse the Go module cache during DEB packaging - #518
Merged
Merged
Conversation
The DEB workflow passed vendor as OMNIBUS_GOMODCACHE. Omnibus forwards this as GOMODCACHE while agent.build uses -mod=readonly, so it redownloaded dependencies into vendor instead of reusing the cache image. The spike merge build failed during one of those redundant downloads. Resolve the module cache before Omnibus changes GOPATH. Offline reproduction with checksum verification retained fails with the old path and passes with the populated cache. Parsed workflow comparison and offline Zizmor passed. Tracks StackVista/stackstate#561.
LouisLotter
approved these changes
Sep 15, 2026
LouisParkin
commented
Sep 15, 2026
LouisParkin
left a comment
Author
There was a problem hiding this comment.
Reviewed be48d78 against STAC-25490-otel-spike: no blocking findings.
Traced the argument through tasks/omnibus.py into the installer/agent recipes. Resolving GOMODCACHE before Omnibus overrides GOPATH correctly preserves the populated cache; vendor/ cannot substitute for it when agent.build uses -mod=readonly.
Validation:
- Independent offline reproduction with a ZIP-only module cache and a changed
GOPATH: the old path fails, the corrected path builds;go mod verifypasses. - Parsed workflow comparison confirms only the cache argument changes executable behavior. Offline Zizmor reports no findings under the existing configuration.
- CI run 34956835540 built both DEBs, passed branding checks, and built/smoke-tested both container architectures. Logs show
/go/pkg/modin the Omnibus recipes and no subsequent Go download messages. Lint/unit and binary workflows also passed.
The earlier workspace preparation still downloads some modules, so this fixes redundant Omnibus downloads rather than making the whole build offline. PR signing/publication jobs were correctly skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEB packaging passed
vendor/asGOMODCACHE, so Omnibus redownloaded modules despite the populated CI cache. Usego env GOMODCACHEbefore Omnibus changesGOPATH. This removes the redundant downloads that exposed the spike build to a Go proxy failure.Validation: offline reproduction fails with the old path and passes with the corrected cache; parsed workflow comparison and offline Zizmor passed. Full packaging CI remains required.
Tracks https://github.com/StackVista/stackstate/issues/561.