Skip to content

fix(mobile): replace emoji tab-icon stubs with real icons - #581

Open
Olayiwola2904 wants to merge 1 commit into
StayLitCodes:mainfrom
Olayiwola2904:fix/issue-554-mobile-replace-emoji-tab-icon-stubs-with-real
Open

fix(mobile): replace emoji tab-icon stubs with real icons#581
Olayiwola2904 wants to merge 1 commit into
StayLitCodes:mainfrom
Olayiwola2904:fix/issue-554-mobile-replace-emoji-tab-icon-stubs-with-real

Conversation

@Olayiwola2904

Copy link
Copy Markdown

Overview

This PR replaces the temporary emoji/text glyph stubs in the mobile tab bar with proper lucide-react-native icons. The previous TabIcon component rendered text glyphs (, bell emoji, full-width plus) and left a comment saying it would be "replaced by @expo/vector-icons at runtime" — which never happened. This change wires tabBarIcon directly to lucide-react-native components, forwarding color and size props so active/inactive tint colors are preserved and no emoji font fallback occurs on iOS or Android.

Related Issue

Closes #

Changes

🖼️ Tab Icon Replacement

  • [REPLACE] apps/frontend/app/(tabs)/_layout.tsx
    • Removed the TabIcon component that rendered text glyphs with a runtime-replacement comment.
    • Replaced the glyph stubs with lucide-react-native icons (Menu, Bell, Plus) in the tabBarIcon render prop.
    • Updated the render prop to pass color and size directly to the icon components.
    • Eliminated the emoji font fallback and the unused @expo/vector-icons comment.

Verification Results

npm run lint -- "apps/frontend/app/(tabs)/_layout.tsx"
✅ Lint passed

Manual acceptance check:
✅ Tab icons render with lucide-react-native icons (no emoji fallback)
✅ Active/inactive tint colours apply correctly
✅ Icons respect color and size props from tabBarIcon
Acceptance Criteria Status
TabIcon glyph stub is removed and replaced with lucide-react-native icons ✅ Done
Icons respect the color and size props supplied by tabBarIcon ✅ Verified
Active and inactive tint colours still apply correctly ✅ Verified
Icons render consistently on iOS and Android with no emoji font fallback ✅ Verified

Closes #554

@drips-wave

drips-wave Bot commented Aug 25, 2026

Copy link
Copy Markdown

@Olayiwola2904 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@KuchiMercy KuchiMercy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MOBILE] Replace emoji tab-icon stubs with real icons

2 participants