fix(mobile): replace emoji tab-icon stubs with real icons - #581
Open
Olayiwola2904 wants to merge 1 commit into
Open
Conversation
|
@Olayiwola2904 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
KuchiMercy
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the temporary emoji/text glyph stubs in the mobile tab bar with proper
lucide-react-nativeicons. The previousTabIconcomponent rendered text glyphs (≡, bell emoji, full-width plus) and left a comment saying it would be "replaced by @expo/vector-icons at runtime" — which never happened. This change wirestabBarIcondirectly tolucide-react-nativecomponents, forwardingcolorandsizeprops so active/inactive tint colors are preserved and no emoji font fallback occurs on iOS or Android.Related Issue
Closes #
Changes
🖼️ Tab Icon Replacement
apps/frontend/app/(tabs)/_layout.tsxTabIconcomponent that rendered text glyphs with a runtime-replacement comment.lucide-react-nativeicons (Menu,Bell,Plus) in thetabBarIconrender prop.colorandsizedirectly to the icon components.@expo/vector-iconscomment.Verification Results
colorandsizeprops supplied bytabBarIconCloses #554