feat: add extend_deadline entrypoint with joint auth - #595
Open
omoh25 wants to merge 1 commit into
Open
Conversation
Adds a new entrypoint that allows depositor and recipient to jointly move a deadline forward, preserving milestone history and avoiding forced cancel/recreate when work runs legitimately late. - Require auth from both depositor and recipient - New deadline must be strictly > current deadline and > current time (same InvalidDeadline validation as creation) - Reject terminal statuses: Completed, Cancelled, Resolved, Expired - Reject when contract is paused (ContractPaused) - Emit versioned DeadlineExtended event with old and new deadline - 14 tests covering: happy path, single-party auth rejection, earlier-deadline rejection, terminal-state rejection, paused rejection, and interaction with refund_expired
|
@omoh25 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@omoh25 Kindly resolve errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new entrypoint that allows depositor and recipient to jointly move a deadline forward, preserving milestone history and avoiding forced cancel/recreate when work runs legitimately late.
closes #574