Skip to content

Fix/resolve 4 invoice component issues (#588, #587, #586, #585) - #645

Merged
Kingsman-99 merged 4 commits into
Stellar-split:mainfrom
lolandriley-wq:fix/issues-588-587-586-585
Aug 29, 2026
Merged

Fix/resolve 4 invoice component issues (#588, #587, #586, #585)#645
Kingsman-99 merged 4 commits into
Stellar-split:mainfrom
lolandriley-wq:fix/issues-588-587-586-585

Conversation

@lolandriley-wq

Copy link
Copy Markdown
Contributor

Summary

This PR addresses 4 related invoice component issues:

Changes

Issue #587 - InvoiceExportButton

  • Added spinner icon that displays while export is in progress
  • Button is disabled immediately after first click
  • Shows "Generating..." text alongside spinner
  • Returns to normal state after export completes
  • Error toast shown if export fails

Issue #586 - LineItemRow Component

  • Created new LineItemRow.tsx component in /src/components
  • Extracted inline recipient row JSX from RecipientForm
  • Fully typed with TypeScript
  • Supports edit, delete, and amount suggestion functionality
  • Updated RecipientForm to use the new LineItemRow component

Issue #585 - InvoiceTimeline Animation

  • Added expand/collapse functionality to timeline entries with details
  • Smooth CSS height transitions (300ms duration)
  • "Show details" / "Hide details" toggle button
  • Animation respects prefers-reduced-motion media query
  • Details include actor address and transaction hash

Tests

  • Added comprehensive test suite for all fixed components
  • InvoiceListSentinel: Observer cleanup verification
  • InvoiceExportButton: Button state and spinner display
  • LineItemRow: Component rendering and user interactions
  • InvoiceTimeline: Expand/collapse and animation behavior

Closes #588
Closes #587
Closes #586
Closes #585

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@lolandriley-wq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@lolandriley-wq is attempting to deploy a commit to the kingsman-99's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Kingsman-99
Kingsman-99 merged commit de4455b into Stellar-split:main Aug 29, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants