test: implement missing test cases for issues #579-582 - #644
Open
famvilianity-eng wants to merge 4 commits into
Open
test: implement missing test cases for issues #579-582#644famvilianity-eng wants to merge 4 commits into
famvilianity-eng wants to merge 4 commits into
Conversation
Implement event log storage verification test to ensure creation events are properly stored and retrievable with correct invoice_id.
Implement basic recipient encoding test to verify that recipients are properly encoded and stored with correct length preservation.
…oice_creation Implement insurance fund deposit test to verify that invoices are created with correct total amount and fund tracking.
Implement full invoice lifecycle test to verify that event log correctly tracks creation, payment, and release events across invoice lifetime.
|
@famvilianity-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement test-only changes for 4 separate issues:
payment_receivedevent topics and data fields #579: Event log creation event storage testinvoice_createdevent includes cross-chain ref when provided #580: Recipient encoding basic testmilestone_reachedemits event at 25%, 50%, 75%, and 100% thresholds #581: Insurance fund deposit on invoice creation testRepScoredefault values are all zero #582: Event log full invoice lifecycle testEach change is implemented as a separate commit with proper test implementations.
Test plan
Closes #579
Closes #580
Closes #581
Closes #582