feat: implement issues #526 #527 #528 #529 - min recipients, payer history, admin two-step handover, e2e lifecycle test - #649
Open
edwardfavour998-code wants to merge 1 commit into
Conversation
…lit#528 Stellar-split#529 - min recipients, payer history, admin two-step handover, e2e lifecycle test
|
@edwardfavour998-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four Drips Wave issues in a single branch:
#526 — Minimum Recipient Count Enforcement
Added a configurable minimum recipient floor (set_min_recipients / get_min_recipients) stored in instance storage. _create_invoice_inner now panics with
TooFewRecipients when the recipient count falls below the configured minimum (default 2). Prevents the splitting infrastructure from being used as a
plain direct-payment contract.
#527 — Contributor Payment History Query
Introduced PaymentRecord (invoice_id, amount, ledger) in types.rs and a PayerHistory(Address) persistent storage key. Every successful contribution now
appends a record to the payer's history. Added get_payer_history(payer, offset, limit) with pagination support for wallets and dashboards to query full
contribution history without off-chain indexing.
#528 — Contract Admin Transfer with Two-Step Handover
Extended the existing propose_admin / accept_admin flow with event emissions — AdminTransferProposed and AdminTransferCompleted — so off-chain monitors
can track handover state. The two-step pattern (propose → accept with require_auth) was already in place; this completes it with proper observability.
#529 — End-to-End Integration Test for Full Invoice Lifecycle
Created tests/e2e_lifecycle.rs covering the complete invoice lifecycle: three contributors funding a three-way split, token balance assertions before
and after payout, event emission checks, and archival/query verification using MockAuth.
Closes #526
Closes #527
Closes #528
Closes #529
Files Changed
Notes