feat: implement view functions and event updates for issues #595-#598 - #650
Open
kaivegascod-a11y wants to merge 5 commits into
Open
feat: implement view functions and event updates for issues #595-#598#650kaivegascod-a11y wants to merge 5 commits into
kaivegascod-a11y wants to merge 5 commits into
Conversation
Closes Stellar-split#598 Modifies the invoice_refunded event to include the invoice_id in the event data tuple, making it easier for indexers that decode only event data (not topics) to correlate refund events with invoices. The event data now contains (invoice_id, event_seq) instead of just (event_seq).
Closes Stellar-split#598 Adds comprehensive tests to verify that the invoice_refunded event now includes invoice_id in the event data, making it easier for indexers to correlate refund events with invoices without needing to decode event topics.
Closes Stellar-split#597 Adds a new public function to query invoice recipient amounts without retrieving the entire invoice structure. This enables recipients and payers to easily determine individual entitlements without loading full invoice data. Includes comprehensive unit tests verifying returned values match creation inputs.
Closes Stellar-split#596 Adds a new public view function that allows off-chain clients and integrations to query whether the smart contract is currently paused. This enables trustless discovery of the pause state without requiring clients to maintain off-chain configuration. Includes comprehensive unit tests verifying the function returns false initially and true after an admin pause operation.
Closes Stellar-split#595 Adds comprehensive unit tests verifying that the get_platform_fee_bps function returns the correct platform fee basis points. Tests verify both the default zero value and the ability to retrieve custom-set fee values.
|
@kaivegascod-a11y Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements solutions for four related GitHub issues:
Issue #598: Add invoice_id to invoice_refunded event data
Issue #597: Add get_invoice_amounts view function
Issue #596: Add get_contract_paused view function
Issue #595: Add comprehensive tests for get_platform_fee_bps
Test Coverage
All implementations include comprehensive unit tests verifying:
Closes #598
Closes #597
Closes #596
Closes #595