issues/631-634: expand docs, add event naming convention, replace mag… - #651
Open
Dankiddo wants to merge 1 commit into
Open
Conversation
…ic numbers, add Errors sections - Stellar-split#631 expand OverflowBehavior and OverfundingPolicy docs with # Relationship section - Stellar-split#632 import BASIS_POINTS_TOTAL in calc.rs and document typical denom values - Stellar-split#633 add //! module-level doc comment to events.rs explaining naming convention, topic layout, next_seq usage, and symbol_short! vs Symbol::new guidance - Stellar-split#634 add /// # Errors sections to assert_unique_recipients and assert_recipients_have_trustlines in validation.rs - clean .gitignore for test snapshots and generated artifacts
|
@Dankiddo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ic numbers, add Errors sections
OverflowBehaviorandOverfundingPolicydocs to explain their relationship #631 expand OverflowBehavior and OverfundingPolicy docs with # Relationship section10_000withBASIS_POINTS_TOTALconstant incalc.rs#632 import BASIS_POINTS_TOTAL in calc.rs and document typical denom valuesevents.rsexplaining event naming convention #633 add //! module-level doc comment to events.rs explaining naming convention, topic layout, next_seq usage, and symbol_short! vs Symbol::new guidance# Errorssection toassert_unique_recipientsandassert_recipients_have_trustlines#634 add /// # Errors sections to assert_unique_recipients and assert_recipients_have_trustlines in validation.rsOverflowBehaviorandOverfundingPolicydocs to explain their relationship #63110_000withBASIS_POINTS_TOTALconstant incalc.rs#632events.rsexplaining event naming convention #633# Errorssection toassert_unique_recipientsandassert_recipients_have_trustlines#634