fix(pagination): clamp page to prevent u32 overflow - #60
Open
Emelie-Dev wants to merge 2 commits into
Open
Conversation
Contributor
|
resolve conflicts |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where providing extremely large values for the
pagequery parameter (such asu32::MAX) caused a silent wraparound overflow in release builds and a panic in debug builds when computing the paginationoffset.This PR prevents this behavior by checking for
u32arithmetic overflow, returning a clean validation error if the parsed page results in an uncomputable offset, and explicitly enforces integer overflow checks system-wide in release builds.Changes
offsetcomputation inTransactionService::list_for_userto usechecked_subandchecked_mul. This explicitly yields anAppError::Validationif an overflow occurs, resulting in a predictable422 Unprocessable Entityresponse.compute_offsetunit tests insrc/services/transaction.rscovering typical inputs, extremely high values near theu32boundary, and out-of-bounds page parameters to verify proper error propagation.overflow-checks = truein the[profile.release]section ofCargo.toml. This acts as defense in depth against this class of bug appearing anywhere else in the application logic.Validation and Testing
page = 1,page = 42949673, andpage = u32::MAX).Validationerror properly when passing bounds, terminating execution safely.cargo fmtandcargo check.Related Issues
closes #57