BatchForm's per-recipient address/amount Inputs have no label or aria-label — the only financial form in the app with this gap - #66
Open
mrmoney10010-design wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same defect category as the already-filed "Form inputs in AddContact and RecipientStep lack associated label elements" issue in this repo (#10), but in a file that issue doesn't mention: BatchForm.tsx is the only other place in the entire app's financial forms (SendForm, EscrowForm, SubscriptionForm, CreateRequestForm all correctly pass label="..." to every Input/Select) that has this specific gap, and arguably a higher-stakes one — it's per-recipient address and amount entry for a batch of up to 100 payments (MAX_BATCH_RECIPIENTS), sent as a single atomic transaction the user cannot partially undo. A screen-reader user filling out this form hears "edit text" (or similar generic control name) for every recipient row's address and amount fields, with no way to distinguish "recipient 3's address" from "recipient 3's amount" from "recipient 4's address" by name alone — they'd have to rely entirely on DOM/reading order and memory to keep track of which field is which while filling in multiple recipients.
closes #54