fix(batch): reject duplicate recipient addresses and prevent floating-point total drift (#13) - #95
Open
ghzhost wants to merge 1 commit into
Open
Conversation
…-point total drift (StellarSend#13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces cross-row recipient validation and exact integer stroop total calculation for batch payments.
Closes #13.
Changes
superRefineonbatchSchemainBatchForm.tsxto detect duplicate destination addresses across batch items and attach path-specific validation errors directly under the duplicate recipient row.publicKeyfromuseWallet()toBatchFormto display an inline non-blocking warning when any recipient matches the connected account.parseAmountToStroops,xlmToStroops,stroopsToXlm, andcalculateBatchTotalinsrc/lib/stellar.tsto compute batch payment sums via exact BigInt stroop arithmetic (7 decimal places) instead of naiveparseFloatadditions.BatchFormanduseBatchPaymentto usecalculateBatchTotal, preventing floating-point precision drift across many decimal rows.BatchForm.test.tsxfor:senderPublicKey.0.0000001XLM) without floating point drift.Verification
NODE_ENV=test pnpm test: 27 test files, 116 passed (100% green).pnpm build: Completed successfully with clean Vite bundle.