fix(utils): consolidate date and datetime formatting helpers (#28) - #96
Open
ghzhost wants to merge 1 commit into
Open
fix(utils): consolidate date and datetime formatting helpers (#28)#96ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…Send#28) - Update lib/utils.ts date helpers to validate parsed dates against isNaN - Make utils/format.ts delegate formatDate and formatDateTime to lib/utils.ts - Support Date instances and string inputs consistently with graceful unparseable fallbacks - Add test coverage for formatDate and formatDateTime across strings and Date objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates duplicated and divergent date formatting implementations between
src/lib/utils.tsandsrc/utils/format.ts(fixes #28).Changes
src/lib/utils.ts'sformatDate,formatDateTime, andtimeAgoto validatenew Date(iso)againstisNaN(d.getTime()), preventing invalid timestamp renderings.src/utils/format.tsto delegateformatDateandformatDateTimetosrc/lib/utils.ts, accepting bothDateinstances and ISO strings with consistent behavior and graceful fallbacks on malformed date strings.src/utils/format.test.tsverifying date-only formatting, date-time formatting,Dateobjects vs strings, and unparseable input fallbacks.Verification
NODE_ENV=test pnpm test(all 27 test suites / 117 tests passing)pnpm run build(clean TypeScript compilation & Vite build)