skip: skipped webhook delivery logic as requested - #243
Open
probablyABug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #184
Adds structured logging for failed outbound webhook delivery attempts. Each failed attempt now records the webhook ID, event type, attempt number, response status, failure time, and next retry time, allowing operators to monitor webhook delivery failures and retry behavior. The final failed attempt is logged at error level, while intermediate failures use warn level. Webhook payload bodies are intentionally excluded from logs to avoid exposing potentially sensitive data.
Type of Change
Checklist
feat:,fix:,chore:, etc.) — enforced by CI.env, or credentials committed (seeCONTRIBUTING.md)Testing
Added coverage for structured webhook delivery failure logging, including retry attempts, final failures, status codes, retry timestamps, and payload redaction.
How to Test
webhook_id,event_type,attempt_number,status_code,next_retry_at, andfailed_at.attempt_numberincrements correctly.status_codeis recorded asnull.next_retry_atisnull.Test Coverage
Screenshots (if applicable)
Not applicable — this change affects backend logging and observability only.
Additional Notes
Intermediate delivery failures are logged at
warnlevel, while the final failed attempt is escalated toerror. Timeout failures use anullstatus code, and the final attempt uses anullnext_retry_atbecause no further retry is scheduled.Webhook payload contents are deliberately excluded from structured logs to prevent sensitive event data from being exposed through application logs.
For Reviewers