fix(backend): add optimistic concurrency to the cron failure-count fa… - #1189
Open
Emmanuel5vohd wants to merge 1 commit into
Open
Conversation
…llback to prevent lost increments under concurrent cron replicas - Add explicit console.warn when optimistic-concurrency retries are exhausted so operators know a concurrent increment may have been lost (the final non-atomic upsert still records the failure to avoid a silent drop) - The RPC fallback path already had a retry loop with OCC guard; the new warning surfaces the degraded-mode clearly in operator logs - Add integration test (cron-failure-tracker.concurrent-fallback.integration.test.ts) simulating: RPC unavailable + concurrent recordFailure calls + exhausted retries, asserting no silent drop and correct warning emission Closes StellerCraft#1140 Co-authored-by: fix/cron-failure-tracker-fallback-concurrent-loss
|
@Emmanuel5vohd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llback to prevent lost increments under concurrent cron replicas
Closes #1140
Co-authored-by: fix/cron-failure-tracker-fallback-concurrent-loss
Closes #1141
Closes #1140