fix: implement issues 1135, 1136, 1137, 1138 - #1191
Open
sudo-dev-lab wants to merge 4 commits into
Open
Conversation
…thout an upgrade transaction XDR - Add test asserting the specific error message when dryRun=true without upgradeTransactionXdr - Verify that diffReport is still populated in the result even though the dry run did not proceed - Closes StellerCraft#1135
…example to soroban-budget-monitor - Add comprehensive end-to-end example showing addAnalyticsSink and onBudgetAlert working together with trackContractBudget - Clarify why addAnalyticsSink is preferred over the deprecated setAnalyticsSink - Improve discoverability for contributors wiring up budget monitoring for the first time - Closes StellerCraft#1136
…suer verification cache at full capacity - Add dedicated test filling cache to MAX_ISSUER_CACHE_ENTRIES - Verify that the oldest entry (first inserted) is evicted when capacity is reached - Assert oldest-first eviction by checking that re-querying the evicted key triggers a fresh Horizon call instead of a cache hit - Closes StellerCraft#1137
…se-level conflict handling Implements Issue StellerCraft#1138: Replace select-then-insert pattern with atomic upsert using database-level ON CONFLICT DO NOTHING. Changes: - Migration 021: Add request_fingerprint column and unique index for atomic upserts - Service: Rewrite generateKey() with lookup → insert → re-select pattern - Tests: Update mocking to reflect atomic upsert behavior and simplify concurrent test This ensures concurrent calls converge on a single key, preventing duplicate charges.
|
@sudo-dev-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements fixes for issues #1135, #1136, #1137, and #1138 across Stellar and backend services.
Issue #1135: Cache eviction strategy for issuer verification
Issue #1136: Soroban budget monitoring documentation
Issue #1137: Contract upgrade orchestrator error handling
Issue #1138: Atomic idempotency key generation
Test Plan
Closes #1135,
Closes #1136,
Closes #1137,
Closes #1138