Fix/issues 1131 1132 1133 1134 - #1192
Open
lami111isah wants to merge 4 commits into
Open
Conversation
…ntract address derivation - Add networkPassphrase parameter to function documentation - Create breaking changes section with before/after examples - Explain rationale for network passphrase requirement - List available network passphrases for common networks
…letter growth - Add test case for event acknowledged on fourth delivery attempt (should not enter dead-letter buffer) - Add test case for staged events cleared on unsubscribe (should not be added to dead-letter buffer) - Both tests verify proper lifecycle handling for ACK failures
…ion expiry at exact boundary - Update addCoSignerSignature to accept optional _now parameter for testing - Add test cases for signature acceptance one moment before expiry boundary - Add test case for exact expiry boundary (now === expiresAt) - Add test cases for rejection after expiry boundary - Add test cases for expireTimedOutSessions behavior at boundaries - Verify both functions agree on expiration status at exact instant - Test boundary cases with one moment before, at, and after expiry
… budget metrics Replace O(n) array.shift() with O(1) circular buffer implementation for soroban budget metrics storage. Maintains fixed-size array of 1000 entries with wrapping write index. Changes: - Use fixed-size array + write index instead of array.shift() - Implement O(1) pushMetric operation - Update getBudgetMetrics to reconstruct circular buffer in insertion order - Update clearBudgetMetrics to reset circular buffer state - Add comprehensive tests for ordering, wrapping, and edge cases - Verify output format unchanged (newest last)
|
@lami111isah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Documentation, Tests, and Performance for Stellar Contracts
Summary
Changes
_nowparameter support (Engineer Unit Test Coverage for Multi-Party Issuance Session Expiry at the Exact Boundary #1133)Testing
Closes #1131
Closes #1132
Closes #1133
Closes #1134