Fix/issues 1123 1124 1125 1126 - #1194
Open
emekaabraham666 wants to merge 4 commits into
Open
Conversation
…boundary values Fixes StellerCraft#1123: Add comprehensive boundary value testing for u64, i64, u128, i128, u256, and i256 serialization round-trips, including exact min/max values and 64-bit segment boundary crossings where off-by-one bit-shifting errors are most likely. Also fixes a bug where u128, i128, u256, and i256 serialization was not wrapping the value objects with proper XDR type constructors (UInt128Parts, Int128Parts, UInt256Parts, Int256Parts).
Fixes StellerCraft#1124: Add comprehensive lifecycle tests for both polling and event-driven modes, including: - Double-start idempotency (does not register second timer/listener) - Stop-then-restart in both modes correctly re-arms monitoring - Event listener registration and removal - Stop idempotency when not started
…d empty-entry snapshots Fixes StellerCraft#1125: Add dedicated property tests for ContractStateSnapshotService.restore() edge cases: - Successfully-decompressed-but-invalid-JSON payloads with improved snapshot-identifying error context - Snapshots with zero entries restoring successfully with empty result - Round-trip snapshot → restore with zero entries
…and override precedence Fixes StellerCraft#1126: Add comprehensive tests for loadComplianceConfig edge cases: - Malformed JSON in each env var independently with proper fallback - Both env vars malformed simultaneously - Override parameter taking complete precedence over env vars - Override with one sibling env var malformed still warns appropriately
|
@emekaabraham666 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive Test Coverage for Stellar Package
Add property-based and edge-case testing across four critical modules:
All tests pass. 124 new test cases covering edge cases and lifecycle transitions.
Closes #1123
Closes #1124
Closes #1125
Closes #1126