admin hardening - #126
Open
Jumongweb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
🔖 Title
Harden admin audit-log access with server-side authorization
📝 Description
This PR closes a critical authorization gap on the
/admincontroller tree. It adds a server-sideAdminGuardthat checks the latestusersrow from Supabase on every request, so access decisions no longer rely only on JWT claims.🔄 Changes Made
src/modules/admin/admin.guard.tsto fetchroleandstatusfresh from Supabase and deny by default unless the user is an active admin.GET /admin/audit-logsand documented the 401/403 responses in Swagger.users.roleconstraint to allow a realadminvalue in the database and updated the user profile DTO accordingly.🗒️ Additional Notes
The guard intentionally trusts the database over the JWT role claim so role grants and revocations take effect immediately on the next request, even before token refresh.