Add predict() coverage to float32 test suite#391
Merged
Conversation
Each existing TestBARTFloat32 and TestBCFFloat32 test now also exercises the predict() code path with float32 inputs, verifying that sampling and prediction are both robust to non-float64 input dtypes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestBARTFloat32andTestBCFFloat32tests now also callpredict()with float32 inputs after sampling, verifying that the predict path is equally robust to non-float64 dtypespredict()output_matches_float64tests add a numerical comparison of predict output between float32 and float64 inputs (rtol=1e-5 for BART, rtol=1e-4 for BCF)Context
Commit
14137970fixed float32 handling in sampling by addingforcecastto the C++ bindings and an explicity_traindtype cast. TheColumnMatrixconstructor does a full element-by-element copy, soforcecastis safe for the Python MCMC path. This PR extends the test coverage to verify prediction is equally safe.Test plan
🤖 Generated with Claude Code