chore(ci): shallow OBS clones + remove dead legacy pieces#84
Closed
styler wants to merge 1 commit into
Closed
Conversation
- Clone obs-studio with --depth 1 --branch $CHECKOUT --shallow-submodules on both platforms instead of a full recursive clone + checkout; saves several minutes per job. - Remove the legacy HMAC GCS uploader setup (CI/gcs npm tool + key.json from GS_KEY_BASE64) — uploads have gone through WIF-authenticated google-github-actions for a while; the step only planted a static key on disk. GS_ACCESS_KEY_ID/GS_KEY_BASE64/GS_SECRET_ACCESS_KEY envs go with it. The CI/gcs directory itself can be deleted with the AppVeyor cleanup (CORE-272). - Remove the no-op GITHUB_WORKSPACE env override (the runner ignores attempts to set GITHUB_* vars). - Remove the installer's RELEASE_NOTES.md download from core/latest — the object does not exist (404 XML saved to disk every build) and the release_notes job reads the repo checkout instead. - Remove the uninstaller's leftover Debug step.
Collaborator
|
Rejecting this one since savings are negligible compared to possible future issues this might introduce with a project which is not under our control |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical cleanup from the pipeline review — no behavior change to what ships.
--depth 1 --branch $CHECKOUT --recursive --shallow-submoduleson both platforms instead of full-history clone + checkout. Should save several minutes per job.Setup GCS uploaderstep wrote a static GCS key (GS_KEY_BASE64) tokey.jsonand npm-installedCI/gcs— nothing invokes it anymore; all uploads use WIF-authenticatedgoogle-github-actions. TheGS_*secrets can be deleted from the repo after this merges; theCI/gcsdirectory can go with the AppVeyor cleanup (CORE-272).GITHUB_WORKSPACEenv override removed (the runner ignoresGITHUB_*overrides).RELEASE_NOTES.mddownload removed from the installer — the GCS object doesn't exist, so every build saved a 404 XML body to disk; the release_notes job reads the repo checkout.Debugstep removed.Related: #81, #83. Found with Jacob's assistant.