Apply subtitle font to OCR character text boxes#11391
Merged
niksedk merged 1 commit intoJun 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends the existing “Appearance → Subtitle font” behavior to additional OCR-related dialogs that were missed previously, ensuring consistent glyph legibility when reviewing/adding OCR character mappings.
Changes:
- Apply
Se.Settings.Appearance.SubtitleTextBoxAndGridFontNameto the OCR character text box (FontFamily) in seven OCR dialog windows. - Use the same guard/pattern as existing OCR secondary windows (set immediately after
UiUtil.MakeTextBox(...)).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/Features/Ocr/NOcr/NOcrInspectWindow.cs | Apply subtitle font to the inspect window “new text” textbox. |
| src/ui/Features/Ocr/NOcr/NOcrDbEditWindow.cs | Apply subtitle font to the DB edit “item text” textbox. |
| src/ui/Features/Ocr/NOcr/NOcrCharacterHistoryWindow.cs | Apply subtitle font to the history window “new text” textbox. |
| src/ui/Features/Ocr/NOcr/NOcrCharacterAddWindow.cs | Apply subtitle font to the add window “new text” textbox. |
| src/ui/Features/Ocr/BinaryOcr/BinaryOcrDbEditWindow.cs | Apply subtitle font to the Binary OCR DB edit “item text” textbox (and add required Avalonia.Media using). |
| src/ui/Features/Ocr/BinaryOcr/BinaryOcrCharacterHistoryWindow.cs | Apply subtitle font to the Binary OCR history window “new text” textbox. |
| src/ui/Features/Ocr/BinaryOcr/BinaryOcrCharacterAddWindow.cs | Apply subtitle font to the Binary OCR add window “new text” textbox. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subtitle font setting (
Appearance → Subtitle font) was already applied to the main OCR window and a few secondary windows, but seven OCR dialogs were missed in #11368. This extends the same pattern to the remaining ones:Each gets the same guard applied immediately after
MakeTextBox, consistent with the existing pattern inBinaryOcrInspectWindowandPromptUnknownWordWindow.