Don't override bare Left/Right when a text input is focused (#11357)#11403
Merged
Conversation
Bare Left/Right are fundamental caret navigation in every text input on every platform. The existing protection in OnKeyDownHandler only returned early when the "Allow single-letter shortcuts in text box" setting was off; with that setting on (or for an arrow key that the user has happened to bind), Left/Right inside the subtitle text box, the Find dialog, or any other TextBox / TextEditor / MaskedTextBox would fire the SE shortcut instead of moving the caret. From the reporter: > When I am editing text in the text box, I want to use … LeftArrow to > skip to the next/previous word. This is a global Windows standard > keyboard shortcut that works in every other app. Bail out of OnKeyDownHandler when the focused element is a text input and the pressed key is bare Left or Right (no modifiers). Modified combinations (Ctrl+Left, Shift+Right, etc.) keep going through the normal shortcut resolution because some users do bind those. Fixes #11357 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bare Left/Right are fundamental caret navigation in every text input on every platform. The existing protection in
OnKeyDownHandleronly returned early when the Allow single-letter shortcuts in text box setting was off; with that setting on (or for an arrow key that the user has happened to bind), Left/Right inside the subtitle text box, the Find dialog, or any other TextBox / TextEditor / MaskedTextBox would fire the SE shortcut instead of moving the caret.From the reporter (#11357):
Change
At the top of the
IsTextInputFocused()branch inMainViewModel.OnKeyDownHandler(MainViewModel.cs:16764), bail out when the pressed key is bare Left or Right (no modifiers):Modified combinations (Ctrl+Left, Shift+Right, Ctrl+Shift+Left, etc.) keep going through the normal shortcut resolution — some users do bind those, and overriding them would surprise them.
The check uses the existing
IsTextInputFocused()helper, so it applies broadly: subtitle text box, original text box, Find dialog, any future window with a text input.Test plan
🤖 Generated with Claude Code