Add Adapter.DeviceConnected / DeviceDisconnected events#81
Open
Kinchul wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
AdapterexposesDeviceFoundfor device discovery, but there is no equivalent event for a device's connection state. To learn that a device connected, a caller must enumerate devices itself and wire up eachDevice's per-deviceConnectedwatch — and even then it can miss connections (see below).This PR adds two adapter-level events as the connection-side twin of
DeviceFound:event DeviceChangeEventHandlerAsync DeviceConnectedevent DeviceChangeEventHandlerAsync DeviceDisconnectedThey fire for any device transitioning to/from connected, regardless of how its
Device1object came to exist.De-duplication
Device.Connectedcan fire twice for one transition — once from the add-accessor replay (FireEventIfPropertyAlreadyTrueAsync) and once from the livePropertiesChanged. (There is an existing// TODO: Suppress duplicate event from OnPropertyChangesat that spot.) The adapter tracks per-device connected state and relays only on an actual edge, soDeviceConnected/ DeviceDisconnected` fire exactly once per transition.Design notes
DeviceFoundevent pattern (add-accessor bootstrap,DeviceFoundEventArgscarrying theDevice).Interlockedso concurrentPropertiesChangedcallbacks can't double-fire.netstandard2.0-compatible (noDictionary.Remove(key, out value)overload).Usage