Add Device RSSIChanged and generic PropertyChanged events#82
Open
Kinchul wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Add
RSSIChangedand genericPropertyChangedevents to DeviceDevice.OnPropertyChangesonly surfacedConnectedandServicesResolved; all otherDevice1property changes were received by the existing property watcher and discarded.This adds two events, reusing that same watcher (no extra D-Bus subscriptions):
RSSIChanged(EventHandler<short>) — typed event carrying the new RSSI in dBm, matching the existing typed-event style. Lets consumers track signal strength across advertisements without polling or re-scanning.PropertyChanged(EventHandler<PropertyChanges>) — generic passthrough of the raw changes for every property, so properties without a dedicated event (e.g. ManufacturerData, TxPower) are reachable without forking the library.Note
Changes covered by a typed event (
Connected,ServicesResolved,RSSI) are also delivered onPropertyChanged; this is documented as intentional on the event.