fix(vuln-scanner): sync reviewed poc gate checks - #48
Merged
Conversation
…m Aeon root Forge exit 0 with no matching tests is not a reproduction. The SKILL examples now cd back to GITHUB_WORKSPACE and pass the clone as --repo. Co-Authored-By: Grok <grok@x.ai>
Content hash + finding line offsets for vuln-scanner SKILL.md. No new reach. Gate still fail-closed on HIGH/CRITICAL without a matching forge pass. Co-Authored-By: Grok <grok@x.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
sync the two maintainer follow-up commits from aeonfun#1008 into this fork.
no tests foundand zero-pass/only-skipped runs even when forge exits 0--repowhy
the fork merged the original poc gate before upstream review. upstream maintainer review found that forge may exit 0 without executing a matching test, which let the fork record a false verified verdict. the skill examples also ran from the audited clone even though the verifier script and allowlist live in the aeon checkout.
verification
bash scripts/tests/test_vuln_poc_gate.sh— all 13 assertions passbash scripts/tests/test_skill_mode.sh— all assertions passgit diff --check— clean&& foundry_matched_pass "$LOG"makes the suite exit 1 with exactlyno-matching-test should blockand0 passed should block; restoring it returns greenagent.robinhood.com, so the real github ci result is authoritativeprovenance: exact reviewed fixes from aeonfun#1008 commits
6b00a07aandf854209e, applied to current fork main.