Allow rubyzip 3.x - #1
Merged
Merged
Conversation
fastlane 2.240 requires rubyzip >= 3.4, and fastlane-plugin-aws_s3 depends on apktools, so the ~> 2.0 pin makes the two impossible to install together. apktools only calls Zip.warn_invalid_date=, Zip::File.foreach and Entry#get_input_stream, which rubyzip 3 still provides. Same change as upstream devunwired#29. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
gallus-mobile is moving to fastlane 2.240.1, which requires rubyzip >= 3.4.
fastlane-plugin-aws_s3depends on apktools, and upstream apktools pinsrubyzip ~> 2.0, so the two can't be installed together.Change
One line in
apktools.gemspec:'rubyzip', '~> 2.0'→'rubyzip', '>= 2.0', '< 4.0'. It's identical to the open upstream PR devunwired/apktools#29; once that is released, this fork can be retired.No code changes are needed: apktools only calls
Zip.warn_invalid_date=,Zip::File.foreachandEntry#get_input_stream, which rubyzip 3.6.0 still provides.Testing
fastlane-plugin-aws_s3uses (ApkXml#parse_xmlonAndroidManifest.xml) was run against a real Gallus beta APK on Ruby 3.4.10 and returned the sameversionCode/versionName/labelwith rubyzip 2.4.1 and 3.6.0.Merging
Please use Create a merge commit (not squash or rebase). gallus-mobile pins this exact commit (
a7d3ab9) in its Gemfile, and a squash or rebase would create a new commit and leave that reference pointing at a commit that is no longer onmaster.Shortcut: sc-214229
🤖 Generated with Claude Code