Hide visible scrolling in background staticNoise#768
Open
aaronkollasch wants to merge 1 commit intoSwordfish90:masterfrom
Open
Hide visible scrolling in background staticNoise#768aaronkollasch wants to merge 1 commit intoSwordfish90:masterfrom
aaronkollasch wants to merge 1 commit intoSwordfish90:masterfrom
Conversation
Randomize vertical position of staticNoise texel and add to existing scrolling of noise texture (both horizontal and vertical; faster in vertical direction)
eric2801
added a commit
to eric2801/cool-retro-term
that referenced
this pull request
Aug 14, 2024
Swordfish90
force-pushed
the
master
branch
2 times, most recently
from
b65f478 to
8cf3031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current background staticNoise is generated by scrolling a noise texture. However, I find that this scrolling is visible, most clearly with large window sizes on high-resolution displays. To me, this distracts from the illusion of static noise.
This PR pseudo-randomizes the vertical position of the staticNoise texel and adds that to the pre-existing scrolling of noise texture (both horizontal and vertical; faster in vertical direction). I've found that produces the best balance of hiding visible scrolling while preserving the smoothness of the previous animation. (The pseudo-random function applied to the time variable seems to produce jerky outputs if used on its own, but they aren't visible when scrolling is also applied.)
The static noise still isn't perfect on large windows with this PR applied (mostly due to the fixed 512x512 texture), but the obvious scrolling artifact is removed.