[Bugfix] Incorrect Unit Net Price #432
Open
tomkalon wants to merge 2 commits into
Open
Conversation
…d ensure compatibility with tax calculators. Updated tests and added fallback for cases without a calculator.
tomkalon
changed the title
UnitNetPriceProvider to handle taxes included in prices an…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When no CalculatorInterface is injected (the deprecated path),
UnitNetPriceProvidernow recalculates the included tax from the full unit price (unitPrice − unitPrice/(1+rate)) instead ofsubtracting the neutral adjustment's getAmount(). That old amount is computed on the discounted, post-promotion price, so subtracting it from the full unit price produced a net price that diverged
from the actual one (e.g. 10740 instead of 10000 on a €120 item with 20% included tax and a 37% discount).