Conversation
ResetPasswordHelperInterface::generateResetToken() has always accepted an optional $resetRequestLifetime, but the interface commented out the parameter rather than declaring it, with a note "to be added to interface in 2.0". This means any consumer relying on the interface type-hint (e.g. for static analysis, mocking, or decorating) sees a 1-parameter method while the concrete ResetPasswordHelper takes 2, which PHPStan (and other tools) correctly flag as an arity mismatch. This exact change already landed on the 2.x branch in SymfonyCasts#300, but that branch has had no activity since August 2024. Since PHP allows calling a method with more arguments than an interface declares (extra args are simply ignored, not a fatal error) and adding an optional trailing parameter to an interface doesn't break existing implementations, this is safe to land on main without waiting for a 2.0 release. Also drops the now-stale PHPStan baseline entry for the docblock/signature mismatch this was previously suppressing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResetPasswordHelperInterface::generateResetToken() has always accepted an optional $resetRequestLifetime, but the interface commented out the parameter rather than declaring it, with a note "to be added to interface in 2.0". This means any consumer relying on the interface type-hint (e.g. for static analysis, mocking, or decorating) sees a 1-parameter method while the concrete ResetPasswordHelper takes 2, which PHPStan (and other tools) correctly flag as an arity mismatch.
This exact change already landed on the 2.x branch in #300, but that branch has had no activity since August 2024. Since PHP allows calling a method with more arguments than an interface declares (extra args are simply ignored, not a fatal error) and adding an optional trailing parameter to an interface doesn't break existing implementations, this is safe to land on main without waiting for a 2.0 release.
Also drops the now-stale PHPStan baseline entry for the docblock/signature mismatch this was previously suppressing.