Conversation
runBuild() takes a single input and the command passed it $this->inputPaths[0], so configuring several input_css files built only the first one. The reported workaround was to run tailwind:build once per file. Tailwind takes one -i/-o pair per run, so the command now starts one process per configured input and waits on all of them. Starting them together is also what makes --watch cover every file. An explicit input_css argument still builds that one file only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78
runBuild()takes a single input, and the command passed it$this->inputPaths[0], so configuring severalinput_cssfiles built only the first one. That is why @kniziol's workaround was to runtailwind:buildonce per file.You called it a problem upstream, and the binary part is true: Tailwind takes one
-i/-opair per run. The consequence is not that nothing can be done though, only that it needs one run per input, which is what the command now does. It starts a process per configured input and waits on all of them. sass-bundle does not have this problem only because Dart Sass acceptsinput:outputpairs in a single pass.Two things fall out of it:
--watchnow covers every input.runBuild()already started the process and returned it, so starting them together and waiting afterwards keeps them all watching, where only the first one was watched before.Passing
input_cssexplicitly still builds that one file only.The new test fails on
1.xwithsecond.built.cssmissing. Suite is green at 50 tests, and php-cs-fixer is clean.