feat: add feedback read/triage MCP tools (PROJ-668) - #296
Merged
Conversation
…sue MCP tools (PROJ-668) Feedback read/triage was REST-only; only source management had MCP parity. Adds the three missing MCP tools, delegating to the existing service functions. update_feedback_status/convert_feedback_to_issue drop the projectId requirement on the MCP surface (resolved from the feedback row instead), matching the pattern already used by the feedback-sources MCP tools; REST still scopes by the URL path's projectId. submit_feedback remains deliberately absent (anonymous ingest has no ServiceCtx user/role to act as). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ARvtjr1d531r7ukzRd896Y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_feedback,update_feedback_status, andconvert_feedback_to_issueMCP tools inapps/api/src/mcp/feedback.ts, delegating to the existingservices/feedback.tsfunctions — closing the REST/MCP parity gap left by PROJ-378 (which only shipped MCP parity for feedback source management).update_feedback_statusandconvert_feedback_to_issuedrop theprojectIdrequirement on the MCP surface: the service now resolves the project from the feedback row itself (requireFeedbackScope) whenprojectIdis omitted, matching the existing pattern used by the feedback-sources MCP tools (seeUpdateFeedbackSourceSchema's comment). REST routes are unaffected — they still always pass the URL path'sprojectId, so a mismatched row still 404s.submit_feedbackremains deliberately absent from MCP (anonymous ingest, noServiceCtxuser/role to act as) — documented in AGENTS.md's parity-exceptions list, updated to reflect that only the anonymous submit endpoint is REST-only now.mcp-parity.node.test.tsexceptions forlistFeedback/updateFeedbackStatus/convertFeedbackToIssue(previously exempted pending PROJ-634/agent-access consideration).Design decisions / tradeoffs
projectIdoptional (Zod), since the feedback-sources domain already established this exact "REST passes projectId, MCP resolves it" convention. Keeps one code path per operation.list_feedback's MCP schema keepsprojectIdrequired (per the ticket's acceptance criteria) since there's no natural way to resolve "all feedback for a project" from anything but the project id itself.Test plan
pnpm --filter @projektor/api test feedback— 74 passed (new MCP-tool test cases cover role guards for list/update/convert, and shape parity with the equivalent REST endpoints)pnpm --filter @projektor/api test:coveragepnpm --filter @projektor/db testpnpm --filter @projektor/web test:coveragepnpm --filter @projektor/web buildpnpm --filter @projektor/docs buildpnpm turbo type-checkpnpm lintpnpm gen:docs— no diff beyond the expected tool-catalog/mcp-stats/conventions regeneration🤖 Generated with Claude Code
https://claude.ai/code/session_01ARvtjr1d531r7ukzRd896Y