fix: stale-counts policy correction and example-dialogue skip#38
Merged
TMHSDigital merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
The cursor-plugin and mcp-server type-level skip_checks entries in drift-checker.config.json have been suppressing stale-counts entirely on 8 of 9 tool repos since v1.7.5. This was a wider suppression than intended - the policy was meant to exempt narrative-aggregate prose in AGENTS.md and CLAUDE.md, not silence the check on every file in those repo types. Empirical evidence of the over-suppression: the DTD#13 investigation discovered an off-by-one drift in steam-api-reference/SKILL.md (TMHSDigital/Steam-Cursor-Plugin#13) that the production drift-check had been silently missing. Three changes: 1. Removes the type-level stale-counts entries from standards/drift-checker.config.json. The cursor-plugin type now skips nothing; mcp-server still skips required-refs. 2. Adds a hardcoded AGENTS.md / CLAUDE.md skip in stale_counts.py. The narrative-aggregate convention belongs in the check's logic, not in repo-level config that over-suppressed. 3. Implements DTD#37: skips counts inside ## Example sections and on lines beginning with **User:** / **Assistant:** dialogue markers. Handles the category C false positive identified in Home-Lab's secrets-management/SKILL.md. Regression tests added including the Steam off-by-one as a fixture so that future re-suppression cannot go unnoticed. Existing AGENTS.md-based pragma and emergency-skip tests were ported to SKILL.md (the only file type stale-counts now scrutinizes by default in the absence of hardcoded skips). Closes #12, closes #37. Refs #13. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Made-with: Cursor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
TMHSDigital
deleted the
fix/stale-counts-policy-and-example-dialogue-skip
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the over-broad type-level stale-counts suppression that has been disabling the check on 8 of 9 tool repos since v1.7.5.
Three changes bundled (closes #12, closes #37):
stale-countsentries fromstandards/drift-checker.config.json. The cursor-plugin type now skips nothing; mcp-server still skipsrequired-refs.AGENTS.md/CLAUDE.mdskip instale_counts.py(narrative-aggregate policy encoded in the check itself, where it belongs).## Examplesections and on lines beginning with**User:**/**Assistant:**markers.Why
The DTD#12 investigation found that the cursor-plugin and mcp-server
skip_checksentries were a whole-check suppression, not a file-scoped one. Empirical evidence: an off-by-one drift in Steam'ssteam-api-reference/SKILL.md(TMHSDigital/Steam-Cursor-Plugin#13) had been silently missed by production drift-check across multiple v1.x releases. Manually running stale_counts.py during DTD#13 investigation surfaced it.Surfaces the policy where it belongs (in the check's logic) so future per-repo configs do not need to know the AGENTS/CLAUDE convention.
Tests
Regression suite expanded from 9 to 17 tests:
## Example Interactionsections and on**User:**/**Assistant:**lines##-or-shallower headingAll 202 tests pass locally on Windows / Python 3.13.
Verification plan after merge
Run drift-check against
Steam-Cursor-PluginandHome-Lab-Developer-Toolsand confirm:Version
VERSION 1.8.5 -> 1.9.0 (MINOR — observable behavior change: stale-counts re-enabled on 8 tool repos that were previously silenced).