chore: add validate-counts job for README aggregate count enforcement#33
Merged
TMHSDigital merged 1 commit intomainfrom Apr 26, 2026
Merged
chore: add validate-counts job for README aggregate count enforcement#33TMHSDigital merged 1 commit intomainfrom
TMHSDigital merged 1 commit intomainfrom
Conversation
Adds a validate-counts job that enforces README.md aggregate count claims match the actual filesystem counts of skills/SKILL.md and rules/*.mdc. Mirrors the canonical pattern shipping in CFX and Unity. Filesystem walk (not plugin.json introspection) because this repo uses glob-based plugin.json (`"skills": ["skills/**/SKILL.md"]`), where len(m['skills']) would always return 1. The walk approach matches what the existing "Count components" step already does informationally; this job promotes it to enforcement. Currently passes (skill/rule counts match README claims). Pure CI hardening; catches future drift before it ships. Refs TMHSDigital/Developer-Tools-Directory#39. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Made-with: Cursor
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
validate-countsjob per the canonical pattern from CFX/Unity, adapted to use a filesystem walk instead ofplugin.jsonintrospection (this repo'splugin.jsonis glob-based, solen(m['skills'])would always be 1).The job enforces that
README.mdaggregate count claims (e.g."17 skills","10 rules") match actual on-disk counts. Currently passes; pure CI hardening that catches future drift before it ships.Complementary to the ecosystem-wide
drift-check stale-countspass (warn-only): this job hard-fails CI on the headline count specifically.Canary for the 6-repo rollout per TMHSDigital/Developer-Tools-Directory#39. Design doc:
dtd39-canonical-pattern.md.