Prevent Aladin chart from blocking page load#1618
Open
Fingel wants to merge 1 commit into
Open
Conversation
Moves the javascript into a self contained file, so that it can be
loaded in the {% extra_javascaript %} block which is outside of <body>,
thus preventing it from blocking the loading of the rest of the page.
Required some refactoring as the original JS used template variables,
which needed to be converted to parameters for the standalone function.
3 tasks
jchate6
approved these changes
Jul 17, 2026
jchate6
left a comment
jchate6
left a comment
Contributor
There was a problem hiding this comment.
This is great. A few questions:
- Can we make it so there is a spinning wheel or equivalent while loading the finder?
- The finder still feels very slow. the main aladin star chart on the Target Details page is much faster. Is there anything we can do to speed up the individual target finder chart?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the javascript into a self contained file, so that it can be loaded in the {% extra_javascaript %} block which is outside of <body>, thus preventing it from blocking the loading of the rest of the page.
Required some refactoring as the original JS used template variables, which needed to be converted to parameters for the standalone function.