Remove special unique constraints ReducedDatums#1624
Open
jchate6 wants to merge 1 commit into
Open
Conversation
…standard constraints are sufficient
1 task
jchate6
changed the title
Contributor
Author
|
@Fingel Without these constraints, I think we need to add some check in the API loop to make sure we aren't ingesting identical data. I'm not sure where that should be... Maybe we just need to include more fields in the constraints, rather than remove them, but this feels like it can be solved by a Suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unique constraints we used to use were necessary because validating on the "value" field wasn't possible. This is no longer the case.