fix(docker): runtime build toolchain for better-sqlite3#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second hotfix for the v0.9.0 release Docker image.
After the Buildx fix (#24) let the Docker build actually run,
publish-dockerfailed at the runtime stage:npm ci --omit=devrebuilds better-sqlite3, which bumped 12.8.0 -> 12.10.0 this cycle and no longer resolves a usable prebuilt fornode:20-slim, so it falls back to node-gyp and fails (the runtime stage had no build tools). Dockerfile was unchanged since v0.8.6 — the dependency bump exposed the latent gap.Fix: install python3/make/g++ in the runtime stage, run
npm ci --omit=dev, then purge them in the same layer (image stays slim).--ignore-scriptswas rejected: 8 prod deps (sharp, onnxruntime-node, ...) have native install scripts that must run.Verified 100% locally before pushing:
docker build .succeeds (both stages)docker run --helpruns the CLInpm teleton@0.9.0 is already published; re-tagging after merge only rebuilds the Docker image (publish-npm / publish-sdk / create-release skip via their idempotency checks).