Skip to content

Fix stale response race condition in async search #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iNalgiev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix stale response race condition in async search #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/autoComplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ export default function autoComplete(config) {
maxResults: 5,
};
this.resultItem = { tag: "li" };
// Request ID counter to detect and discard stale async responses
this._requestId = 0;
// Set all Configuration options
configure(this);
// Stage API methods
Expand Down
4 changes: 4 additions & 0 deletions src/services/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@ export default async function (ctx, q) {

// Validate trigger condition
if (condition) {
// Track this request to detect stale responses
const requestId = ++ctx._requestId;
// Get from source
await getData(ctx, queryVal);
// Discard if a newer request has been made since this one started
if (ctx._requestId !== requestId) return;
// Check if data fetch failed
if (ctx.feedback instanceof Error) return;
// Find matching results to the query
Expand Down