Reject N less than two in reference scrypt#407
Open
achimala wants to merge 1 commit into
Open
Conversation
This was referenced May 30, 2026
Member
|
Thanks, code looks great! One nitpick in the git commit message: please wrap the lines less than 80 chars. I tend to wrap at 76 or 78 chars. |
crypto_scrypt() accepts powers of two for N, but N == 1 leaves smix() without a meaningful iteration count. Treat N values below 2 as invalid and keep the implementation comments in sync.
achimala
force-pushed
the
codex/ref-param-n-one
branch
from
e274ab2 to
a93cb14
Compare
Author
|
Thanks, updated. I amended the commit message to wrap before 80 chars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
N < 2in the referencecrypto_scrypt()parameter validationNmust be a power of two greater than 1Tests
git diff --checkSplit out from #405.