Fix OSW dataset filename classification for names#76
Merged
Conversation
## Dev Board Ticket - https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3750 ## Changes - Fixed dataset file classification to use supported filename patterns instead of loose substring matching. - Prevented files like `River._edges_.nodes.geojson` from being incorrectly classified as `edges`. - Added support for the four accepted filename formats: `<dataset>.geojson`, `*.<dataset>.geojson`, `<dataset>.OSW.geojson`, and `*.<dataset>.OSW.geojson`. - Updated unsupported filename messaging, README documentation, changelog, and package version to `0.4.4`. - Added regression coverage using `tests/assets/3750.zip`. ## Testing - `python -m pytest tests/unit_tests/test_extracted_data_validator.py -q` - `python -m pytest tests/unit_tests/test_osw_validation.py -q` - `python -m pytest tests/unit_tests/test_osw_validation_extras.py -q`
shweta2101
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
Changes
River._edges_.nodes.geojsonfrom being incorrectly classified asedges.<dataset>.geojson,*.<dataset>.geojson,<dataset>.OSW.geojson, and*.<dataset>.OSW.geojson.0.4.4.tests/assets/3750.zip.Testing
python -m pytest tests/unit_tests/test_extracted_data_validator.py -qpython -m pytest tests/unit_tests/test_osw_validation.py -qpython -m pytest tests/unit_tests/test_osw_validation_extras.py -q