scope duplicate-flag detection to command boundaries - #191
Merged
Conversation
Owner
|
I was a bit worried about this possible edge case. I probably should have asked for this to be covered by tests in the original PR. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
False duplicate error across command boundaries
Duplicate detection shares one used-flag set as it walks the tree, and since a command keeps
parent == nullptrit acts as its own detection root. Declaring a flag inside a command and then a same-named flag in a parent scope (sayrun's-mfollowed by a top-level-m) is rejected as a duplicate even though the two live in separate namespaces; the reverse declaration order and reuse between sibling commands are already accepted, so the behaviour is order dependent. Guarding the descent withIsGroup(), which is false for a command, keeps detection within a single scope while genuine duplicates in the parser, a group, or one command are still caught. The added tests fail on master and pass with the change.