QA피드백을 적용합니다. - #347
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several updates, including enabling scrolling and limiting the visible item count in DropDownBox, adding "bullet" support to the item filter, ensuring UI bindings in SetCharacterViewController run on the main thread, and managing the visibility of the recommendation comment view on first launch. Feedback focuses on avoiding tight coupling in RecommendationMainViewController by replacing a direct cast to BottomTabBarController with a callback closure, and extracting hardcoded magic numbers in DropDownBox into meaningful constants.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
📌 이슈
✅ 작업 사항
1. 직업 드롭다운 최대 4개 항목 표시 후 스크롤 처리
DropDownBox.swiftisScrollEnabled = false→true로 변경min(items.count, 4)적용하여 최대 4개 항목만 노출, 이후 스크롤2. 불릿 아이템 필터 누락 수정
ParseItemFilterResultUseCaseImpl.swiftcategoryIdMap에"불릿": 82추가3. SetCharacter 화면 백그라운드 스레드 UI 업데이트 경고 수정
SetCharacterViewController.swiftisLevelValid,isButtonEnabled바인딩에observe(on: MainScheduler.instance)누락으로 인해 NSURLSession 백그라운드 스레드에서 UI(InputBox.setType) 접근하던 문제 수정4. 추천탭 진입 시 말풍선 이미지 즉시 숨김 처리
RecommendationMainReactor.swift,RecommendationMainViewController.swiftrecommendationCommentView) 노출, 추천탭 진입 즉시 숨김shouldHideCommentViewState 및setHideCommentViewMutation 추가viewWillAppear시.setHideCommentView(true)를 가장 먼저 방출bindViewState에서 상태 관찰 →checkRecommendationFirstLaunch(isFirst: true)호출