Skip to content

QA피드백을 적용합니다. - #347

Merged
pinocchio22 merged 5 commits into
devfrom
fix/#346-qa-feedback-apply
Jul 15, 2026
Merged

QA피드백을 적용합니다.#347
pinocchio22 merged 5 commits into
devfrom
fix/#346-qa-feedback-apply

Conversation

@dongglehada

Copy link
Copy Markdown
Member

📌 이슈

✅ 작업 사항

1. 직업 드롭다운 최대 4개 항목 표시 후 스크롤 처리

  • DropDownBox.swift
  • 드롭다운 목록이 길어지는 문제 수정
  • isScrollEnabled = falsetrue 로 변경
  • 높이 계산 시 min(items.count, 4) 적용하여 최대 4개 항목만 노출, 이후 스크롤

2. 불릿 아이템 필터 누락 수정

  • ParseItemFilterResultUseCaseImpl.swift
  • categoryIdMap"불릿": 82 추가
  • 불릿 선택 시 API 필터링이 동작하지 않던 문제 수정

3. SetCharacter 화면 백그라운드 스레드 UI 업데이트 경고 수정

  • SetCharacterViewController.swift
  • isLevelValid, isButtonEnabled 바인딩에 observe(on: MainScheduler.instance) 누락으로 인해 NSURLSession 백그라운드 스레드에서 UI(InputBox.setType) 접근하던 문제 수정
  • Main Thread Checker 경고 제거

4. 추천탭 진입 시 말풍선 이미지 즉시 숨김 처리

  • RecommendationMainReactor.swift, RecommendationMainViewController.swift
  • 첫 방문 전까지만 말풍선(recommendationCommentView) 노출, 추천탭 진입 즉시 숨김
  • Reactor에 shouldHideCommentView State 및 setHideCommentView Mutation 추가
  • viewWillAppear.setHideCommentView(true) 를 가장 먼저 방출
  • ViewController bindViewState에서 상태 관찰 → checkRecommendationFirstLaunch(isFirst: true) 호출

@dongglehada dongglehada self-assigned this Jul 15, 2026
@dongglehada dongglehada added the fix 버그 수정, 잔잔바리 수정, 병합 시 충돌 해결 label Jul 15, 2026
@dongglehada
dongglehada requested a review from pinocchio22 July 15, 2026 05:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several updates, including enabling scrolling and limiting the visible item count in DropDownBox, adding "bullet" support to the item filter, ensuring UI bindings in SetCharacterViewController run on the main thread, and managing the visibility of the recommendation comment view on first launch. Feedback focuses on avoiding tight coupling in RecommendationMainViewController by replacing a direct cast to BottomTabBarController with a callback closure, and extracting hardcoded magic numbers in DropDownBox into meaningful constants.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@pinocchio22 pinocchio22 linked an issue Jul 15, 2026 that may be closed by this pull request
@pinocchio22
pinocchio22 merged commit bb7028b into dev Jul 15, 2026
2 checks passed
@pinocchio22
pinocchio22 deleted the fix/#346-qa-feedback-apply branch July 15, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그 수정, 잔잔바리 수정, 병합 시 충돌 해결

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QA 피드백을 적용합니다.

2 participants