[Feat] Apple 로그인 출시 흐름 완성 - #104
Draft
MinHeokChoi wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
🛠️ 작업내용
SecRandomCopyBytes로 32자 raw nonce를 만들고 SHA-256 challenge를 Apple 요청에 연결합니다. 이름·이메일 scope는 요청하지 않습니다.credentialRevokedNotification의 revoked/notFound/transferred 상태에서 account session을 안전하게 무효화합니다. 로컬 루틴 접근은 유지합니다.Moru/docs/AppleLoginReadiness.md에 release blocker로 기록합니다. withdrawal 응답에 Apple token revoke 완료 증거가 없는 점도 blocker로 남깁니다.검증:
📋 추후 진행 상황
📌 리뷰 포인트
✅ Checklist
Closes #103